Bug 142795

Summary:

Function bodies should always include braces

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

oliver, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	msaboff: review+

Description Geoffrey Garen 2015-03-17 15:03:54 PDT

Function bodies should always include braces

Comment 1 Geoffrey Garen 2015-03-17 16:22:14 PDT

Created attachment 248883 [details]
Patch

Comment 2 Geoffrey Garen 2015-03-17 16:30:57 PDT

Created attachment 248884 [details]
Patch

Comment 3 Michael Saboff 2015-03-17 16:57:22 PDT

Comment on attachment 248884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248884&action=review

r=me

> Source/JavaScriptCore/ChangeLog:24
> +        * generate-js-builtins: Ditto.

Ditto what?  Looks like you changed from using linkGlobalCode() to link().

Comment 4 Mark Lam 2015-03-17 17:05:22 PDT

Comment on attachment 248884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248884&action=review

r=me too with comment typo fix.

> Source/JavaScriptCore/ChangeLog:41
> +        leading space because that's what this functinon's comment says is required

/functinon/function/

Comment 5 Geoffrey Garen 2015-03-17 17:07:57 PDT

Committed r181673: <http://trac.webkit.org/changeset/181673>