Bug 142795

Summary: Function bodies should always include braces
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch msaboff: review+

Geoffrey Garen
Reported 2015-03-17 15:03:54 PDT
Function bodies should always include braces
Attachments
Patch (26.19 KB, patch)
2015-03-17 16:22 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (20.87 KB, patch)
2015-03-17 16:30 PDT, Geoffrey Garen 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2015-03-17 16:22:14 PDT
Created attachment 248883 [details] Patch
Geoffrey Garen
Comment 2 2015-03-17 16:30:57 PDT
Created attachment 248884 [details] Patch
Michael Saboff
Comment 3 2015-03-17 16:57:22 PDT
Comment on attachment 248884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248884&action=review r=me > Source/JavaScriptCore/ChangeLog:24 > + * generate-js-builtins: Ditto. Ditto what? Looks like you changed from using linkGlobalCode() to link().
Mark Lam
Comment 4 2015-03-17 17:05:22 PDT
Comment on attachment 248884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248884&action=review r=me too with comment typo fix. > Source/JavaScriptCore/ChangeLog:41 > + leading space because that's what this functinon's comment says is required /functinon/function/
Geoffrey Garen
Comment 5 2015-03-17 17:07:57 PDT
Committed r181673: <http://trac.webkit.org/changeset/181673>
Note You need to log in before you can comment on or make changes to this bug.