Bug 14279

Summary:

Show orgin of data (cache / server)

Product:

WebKit

Reporter:

Peter Speck <speck>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, bweinstein, mrowe, timothy

Priority:

Keywords:

InRadar

Version:

523.x (Safari 3)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch to visually distinguish cached loads	none
Screenshot of cached loads	none

Peter Speck

Reported 2007-06-21 02:29:53 PDT

E.g. 1) was the server not contacted at all due to cached file having expires-header with a future date. 2) was the server contacted, but the cached-version was up to date (304 not modified) 3) was it downloaded from the server. Plus: display the uncompressed size if the server used a compressed content-encoding. Plus: display the server http response code and the message.

Attachments
Proposed patch to visually distinguish cached loads (41.38 KB, patch) 2008-10-19 00:24 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Screenshot of cached loads (69.15 KB, image/png) 2008-10-19 00:26 PDT, Timothy Hatcher	no flags	Details
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2007-06-21 08:01:55 PDT

(In reply to comment #0) > Plus: display the server http response code and the message. I believe this is currently available if you click on each request bar.

Peter Speck

Comment 2 2007-06-21 10:14:42 PDT

(In reply to comment #1) > > Plus: display the server http response code and the message. > > I believe this is currently available if you click on each request bar. It is only the headers but not the status line, i.e. the first line in: HTTP/1.0 200 OK Date: Thu, 21 Jun 2007 17:13:16 GMT Server: VitalityServer/2.0 Content-type: text/html; charset=ISO-8859-1 Content-length: 601

Mark Rowe (bdash)

Comment 3 2007-06-21 14:28:58 PDT

I think this may be tricky to do as the underlying HTTP stack that WebKit uses (Foundation on Mac, CoreFoundation on Windows) simply hands us back the cached response rather than the "real" response from the server when the request is fulfilled from the cache.

Adam Roben (:aroben)

Comment 4 2008-01-29 10:56:04 PST

<rdar://problem/5712799>

Timothy Hatcher

Comment 5 2008-10-19 00:24:36 PDT

Created attachment 24501 [details] Proposed patch to visually distinguish cached loads

mitz

Comment 6 2008-10-19 00:26:21 PDT

Comment on attachment 24501 [details] Proposed patch to visually distinguish cached loads r=me

Timothy Hatcher

Comment 7 2008-10-19 00:26:55 PDT

Created attachment 24502 [details] Screenshot of cached loads

Timothy Hatcher

Comment 8 2008-10-19 20:49:07 PDT

Landed part of this in r37709.

Timothy Hatcher

Comment 9 2008-10-23 13:31:44 PDT

Comment on attachment 24501 [details] Proposed patch to visually distinguish cached loads Clearing the review flag since I plan to do more work for this bug.

Brian Weinstein

Comment 10 2009-11-20 16:17:19 PST

What else would need to be done to get this bug closed? We now show the HTTP status code and the message as well.

Timothy Hatcher

Comment 11 2009-11-20 16:57:56 PST

Not sure… hmm.

Note You need to log in before you can comment on or make changes to this bug.