Bug 142785

Summary: Simple line layout: Change FlowContents::segmentForPosition() to segmentForRun().
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: REOPENED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 142812    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2015-03-17 10:13:04 PDT
This is in transition to support <br>. <br> and a render text can be on the same (start) position.
Attachments
Patch (5.08 KB, patch)
2015-03-17 11:07 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.43 KB, patch)
2015-03-17 15:22 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.32 KB, patch)
2015-03-17 19:01 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2015-03-17 11:07:49 PDT
Created attachment 248854 [details] Patch
zalan
Comment 2 2015-03-17 15:22:59 PDT
Created attachment 248873 [details] Patch
zalan
Comment 3 2015-03-17 19:01:35 PDT
Created attachment 248899 [details] Patch
WebKit Commit Bot
Comment 4 2015-03-17 20:41:27 PDT
Comment on attachment 248899 [details] Patch Clearing flags on attachment: 248899 Committed r181682: <http://trac.webkit.org/changeset/181682>
WebKit Commit Bot
Comment 5 2015-03-17 20:41:31 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6 2015-03-17 23:06:00 PDT
Re-opened since this is blocked by bug 142812
Alexey Proskuryakov
Comment 7 2015-03-17 23:08:13 PDT
This patch depends on <http://trac.webkit.org/changeset/181667>, so it had to be reverted too. I am not aware of any problems with it per se.
Note You need to log in before you can comment on or make changes to this bug.