Bug 142782

Summary: [EFL] Bump gstreamer version to 1.4.4
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, ossy, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 142778    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Csaba Osztrogonác 2015-03-17 04:55:28 PDT 
It is needed for bug142778 and GTK did it in bug138866,
we should use exactly the same version.

I'm going to prepare the patch for it later today.
Comment 1 Csaba Osztrogonác 2015-03-17 08:21:58 PDT 
Created attachment 248847 [details]
Patch

WIP patch, needs testing on our ARM bots too. Copy/pasted from jhbuild.modules of GTK, but leave gst-libav.patch unchanged. It seems many options are unneeded now: --enable-theora, --enable-vorbis, --enable-pulse, --enable-faad and --enable-mpg123. They are already enabled by default without explicit options, so we can match with the GTK's config.
Comment 2 Csaba Osztrogonác 2015-03-17 08:41:28 PDT 
Created attachment 248848 [details]
Patch

really adding all files to the patch
Comment 3 Csaba Osztrogonác 2015-03-17 09:09:53 PDT 
Created attachment 248851 [details]
Patch

resolved conflict in gst-libav.patch
Comment 4 Csaba Osztrogonác 2015-03-17 12:04:11 PDT 
I tested it on our ARM bots, build is happy and tested on x86_64, 
build works fine and there is no layout test regression.

Gyuyoung, do you agree with bumping gstreamer version?
Comment 5 Gyuyoung Kim 2015-03-17 18:53:26 PDT 
(In reply to comment #4)
> I tested it on our ARM bots, build is happy and tested on x86_64, 
> build works fine and there is no layout test regression.
> 
> Gyuyoung, do you agree with bumping gstreamer version?

Why not bumping it ? :) AFAIK, Tizen is going to support gstreamer 1.4 too.
Comment 6 Csaba Osztrogonác 2015-03-18 01:47:50 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > I tested it on our ARM bots, build is happy and tested on x86_64, 
> > build works fine and there is no layout test regression.
> > 
> > Gyuyoung, do you agree with bumping gstreamer version?
> 
> Why not bumping it ? :) AFAIK, Tizen is going to support gstreamer 1.4 too.

I just asked, because I didn't know the roadmap and plans of EFL.
Comment 7 WebKit Commit Bot 2015-03-18 02:33:19 PDT 
Comment on attachment 248851 [details]
Patch

Clearing flags on attachment: 248851

Committed r181690: <http://trac.webkit.org/changeset/181690>
Comment 8 WebKit Commit Bot 2015-03-18 02:33:24 PDT 
All reviewed patches have been landed.  Closing bug.