Bug 142773

Summary: Remove never used "useLayerOnTop" bindings generator argument
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: BindingsAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-03-16 21:52:04 PDT
Remove never used "useLayerOnTop" bindings generator argument. I see it being added in 2006 but I never see it getting used anywhere. Everyone seems to pass 0 for it. I don't even understand its name. So lets just remove it.
Attachments
[PATCH] Proposed Fix (4.89 KB, patch)
2015-03-16 21:54 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (6.11 KB, patch)
2015-03-16 22:11 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-03-16 21:54:05 PDT
Created attachment 248808 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2015-03-16 22:11:30 PDT
Created attachment 248813 [details] [PATCH] Proposed Fix Missed CodeGeneratorTestRunner.pm, which I did not know even existed!
Darin Adler
Comment 3 2015-03-16 23:29:55 PDT
Comment on attachment 248813 [details] [PATCH] Proposed Fix What about $preprocessor? Also seems to be unused.
WebKit Commit Bot
Comment 4 2015-03-17 00:16:03 PDT
Comment on attachment 248813 [details] [PATCH] Proposed Fix Clearing flags on attachment: 248813 Committed r181619: <http://trac.webkit.org/changeset/181619>
WebKit Commit Bot
Comment 5 2015-03-17 00:16:08 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2015-03-17 11:11:22 PDT
(In reply to comment #3) > Comment on attachment 248813 [details] > [PATCH] Proposed Fix > > What about $preprocessor? Also seems to be unused. I'll look at this. It is used by "Parser" but probably not by the sub-generators.
Note You need to log in before you can comment on or make changes to this bug.