Bug 142770

Summary:

Disk cache should support Vary: Cookie

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks	none
another	none

Description Antti Koivisto 2015-03-16 21:18:51 PDT

Vary: Cookie tells the cache not to use the entry if the cookie has changed.

Comment 1 Antti Koivisto 2015-03-16 21:19:31 PDT

rdar://problem/19764945

Comment 2 Antti Koivisto 2015-03-16 21:33:58 PDT

Created attachment 248804 [details]
patch

Comment 3 Build Bot 2015-03-16 22:09:23 PDT

Comment on attachment 248804 [details]
patch

Attachment 248804 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5195992571838464

New failing tests:
http/tests/cache/disk-cache-vary-cookie.html

Comment 4 Build Bot 2015-03-16 22:09:26 PDT

Created attachment 248812 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 5 Pratik Solanki 2015-03-16 22:15:31 PDT

Comment on attachment 248804 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248804&action=review

> Source/WebKit2/ChangeLog:9
> +        Fetch then explicitly when resolving Vary: Cookie.

then -> them

> Source/WebKit2/ChangeLog:13
> +        reasonable cases though. Fetching cookies for every request might be too expensive for this rarely used feature.

Would it be worth having an assert to catch cases where cookies change in between? i.e. fetch the cookies for every request in debug builds and compare to what we saved.

Comment 6 Antti Koivisto 2015-03-16 22:29:18 PDT

Created attachment 248823 [details]
another

Comment 7 Antti Koivisto 2015-03-16 22:29:59 PDT

> Would it be worth having an assert to catch cases where cookies change in
> between? i.e. fetch the cookies for every request in debug builds and
> compare to what we saved.

Not sure what we would do with that information though.

Comment 8 WebKit Commit Bot 2015-03-17 09:09:42 PDT

Comment on attachment 248823 [details]
another

Clearing flags on attachment: 248823

Committed r181651: <http://trac.webkit.org/changeset/181651>

Comment 9 WebKit Commit Bot 2015-03-17 09:09:46 PDT

All reviewed patches have been landed.  Closing bug.