Bug 142770

Summary: Disk cache should support Vary: Cookie
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks
none
another none

Antti Koivisto
Reported 2015-03-16 21:18:51 PDT
Vary: Cookie tells the cache not to use the entry if the cookie has changed.
Attachments
patch (7.40 KB, patch)
2015-03-16 21:33 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (589.26 KB, application/zip)
2015-03-16 22:09 PDT, Build Bot 		no flags
Details
another (8.54 KB, patch)
2015-03-16 22:29 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-03-16 21:19:31 PDT
rdar://problem/19764945
Antti Koivisto
Comment 2 2015-03-16 21:33:58 PDT
Created attachment 248804 [details] patch
Build Bot
Comment 3 2015-03-16 22:09:23 PDT
Comment on attachment 248804 [details] patch Attachment 248804 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5195992571838464 New failing tests: http/tests/cache/disk-cache-vary-cookie.html
Build Bot
Comment 4 2015-03-16 22:09:26 PDT
Created attachment 248812 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Pratik Solanki
Comment 5 2015-03-16 22:15:31 PDT
Comment on attachment 248804 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=248804&action=review > Source/WebKit2/ChangeLog:9 > + Fetch then explicitly when resolving Vary: Cookie. then -> them > Source/WebKit2/ChangeLog:13 > + reasonable cases though. Fetching cookies for every request might be too expensive for this rarely used feature. Would it be worth having an assert to catch cases where cookies change in between? i.e. fetch the cookies for every request in debug builds and compare to what we saved.
Antti Koivisto
Comment 6 2015-03-16 22:29:18 PDT
Created attachment 248823 [details] another
Antti Koivisto
Comment 7 2015-03-16 22:29:59 PDT
> Would it be worth having an assert to catch cases where cookies change in > between? i.e. fetch the cookies for every request in debug builds and > compare to what we saved. Not sure what we would do with that information though.
WebKit Commit Bot
Comment 8 2015-03-17 09:09:42 PDT
Comment on attachment 248823 [details] another Clearing flags on attachment: 248823 Committed r181651: <http://trac.webkit.org/changeset/181651>
WebKit Commit Bot
Comment 9 2015-03-17 09:09:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.