Bug 142762 – Generalize the Document code that maintains a set of nodes with event handlers

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Generalize the Document code that maintains a set of nodes with event handlers

[Simon Fraser (smfr)]

Created attachment 248779 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 248783 [details]
Patch

[Darin Adler]

Comment on attachment 248783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248783&action=review

> Source/WebCore/testing/Internals.cpp:1216
> -    const TouchEventTargetSet* touchHandlers = document->touchEventTargets();
> +    const EventTargetSet* touchHandlers = document->touchEventTargets();

I think auto is better for things like this.

> Source/WebCore/testing/Internals.cpp:1222
> -    for (TouchEventTargetSet::const_iterator iter = touchHandlers->begin(); iter != touchHandlers->end(); ++iter)
> +    for (EventTargetSet::const_iterator iter = touchHandlers->begin(); iter != touchHandlers->end(); ++iter)
>          count += iter->value;

This should be a modern for loop:

    for (auto& handler : *touchHandlers)
        count += handler.value;

[Simon Fraser (smfr)]

https://trac.webkit.org/r181615