Bug 142761

Summary: [CMake][EFL] Build test tools only for developer mode
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ossy: review+

Gyuyoung Kim
Reported 2015-03-16 18:50:53 PDT
Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode.
Attachments
Patch (5.10 KB, patch)
2015-03-16 18:52 PDT, Gyuyoung Kim 		ossy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-03-16 18:52:01 PDT
Created attachment 248777 [details] Patch
Csaba Osztrogonác
Comment 2 2015-03-17 00:35:01 PDT
Comment on attachment 248777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248777&action=review LGTM > Tools/ChangeLog:8 > + Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode. Using release mode is a little bit confusing here, I prefer production mode for non-developer build. > ChangeLog:8 > + Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode. ditto
Gyuyoung Kim
Comment 3 2015-03-17 00:56:15 PDT
Committed r181621: <http://trac.webkit.org/changeset/181621>
Gyuyoung Kim
Comment 4 2015-03-17 00:57:12 PDT
(In reply to comment #2) > Comment on attachment 248777 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248777&action=review > > LGTM > > > Tools/ChangeLog:8 > > + Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode. > > Using release mode is a little bit confusing here, I prefer production mode > for non-developer build. > > > ChangeLog:8 > > + Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode. > > ditto Ok, I land this patch after fixing it.
Note You need to log in before you can comment on or make changes to this bug.