Web Inspector: Don't clear the console when navigating to a different page

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Steps:

0. Open console for this page
1. Right click on the console and set "Keep Log on Reload"
2. Log something, say, 1+1
3. Navigate to a different page, say http://coub.com/view/49yix

Expected result:
Console keeps 1+1 message in the history

Actual result:
Console got cleared.

"Keep Log on Reload" does NOT prevent messages from being erased when navigating to another page. I find this behavior very unpleasant while debugging HTML5 history API on my personal website.

[Radar WebKit Bug Importer]

<rdar://problem/20179772>

[Devin Rousso]

Created attachment 256515 [details]
Patch

[Timothy Hatcher]

Comment on attachment 256515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256515&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        (WebInspector.LogManager): No longer distinguishes from page refreshes and page navigations for console clearing.

The context menu to toggle this is still called "Keep Log on Reload", so that would need to change.

> Source/WebInspectorUI/UserInterface/Controllers/LogManager.js:80
> +            if (!this.clearLogOnReloadSetting.value)

Ditto for the setting name.

[Devin Rousso]

Created attachment 256528 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 256528 [details]
Patch

Clearing flags on attachment: 256528

Committed r186645: <http://trac.webkit.org/changeset/186645>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.