Bug 142740

Summary: Remove setCachedImage from HTMLImageElement since it is not used
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yoav Weiss
Reported 2015-03-16 11:41:27 PDT
Remove setCachedImage from HTMLImageElement since it is not used
Attachments
Patch (1.47 KB, patch)
2015-03-16 11:43 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2015-03-16 15:29 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2015-03-16 11:43:37 PDT
Created attachment 248737 [details] Patch
Yoav Weiss
Comment 2 2015-03-16 11:51:24 PDT
While working on https://bugs.webkit.org/show_bug.cgi?id=142694 I realized setCachedImage is just dead code, so I thought removing it as a separate patch would be best.
Chris Dumez
Comment 3 2015-03-16 11:56:18 PDT
Comment on attachment 248737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248737&action=review r=me % nit. > Source/WebCore/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). Nit: This is supposed to be between the bug URL and the changeling description.
Yoav Weiss
Comment 4 2015-03-16 15:29:05 PDT
Created attachment 248754 [details] Patch
WebKit Commit Bot
Comment 5 2015-03-16 16:13:30 PDT
Comment on attachment 248754 [details] Patch Clearing flags on attachment: 248754 Committed r181591: <http://trac.webkit.org/changeset/181591>
WebKit Commit Bot
Comment 6 2015-03-16 16:13:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.