Bug 142736

Summary:

Removed the concept of 'bodyIncludesBraces' from the JSC parser

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

NEW

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review-, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none

Geoffrey Garen

Reported 2015-03-16 11:05:27 PDT

Removed the concept of 'bodyIncludesBraces' from the JSC parser

Attachments
Patch (11.46 KB, patch) 2015-03-16 11:11 PDT, Geoffrey Garen	ggaren: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (807.22 KB, application/zip) 2015-03-16 11:45 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (725.19 KB, application/zip) 2015-03-16 11:52 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2015-03-16 11:11:34 PDT

Created attachment 248733 [details] Patch

Michael Saboff

Comment 2 2015-03-16 11:13:12 PDT

Comment on attachment 248733 [details] Patch r=me

Build Bot

Comment 3 2015-03-16 11:45:13 PDT

Comment on attachment 248733 [details] Patch Attachment 248733 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6547955934822400 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2015-03-16 11:45:16 PDT

Created attachment 248738 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-03-16 11:52:01 PDT

Comment on attachment 248733 [details] Patch Attachment 248733 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5254037981102080 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2015-03-16 11:52:05 PDT

Created attachment 248740 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Geoffrey Garen

Comment 7 2015-03-16 12:38:17 PDT

Comment on attachment 248733 [details] Patch Looks like this patch was wrong.

Ryosuke Niwa

Comment 8 2015-03-16 22:46:23 PDT

(In reply to comment #7) > Comment on attachment 248733 [details] > Patch > > Looks like this patch was wrong. I think you need to fix up the code in linkGlobalCode and/or ::fromGlobalCode because they specify offsets with various assumptions on bracket locations.

Note You need to log in before you can comment on or make changes to this bug.