Bug 142715

Summary: CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+

Benjamin Poulain
Reported 2015-03-15 17:42:18 PDT
CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
Attachments
Patch (161.72 KB, patch)
2015-03-15 17:51 PDT, Benjamin Poulain 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-03-15 17:51:20 PDT
Created attachment 248693 [details] Patch
WebKit Commit Bot
Comment 2 2015-03-15 17:54:06 PDT
Attachment 248693 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/StringCommon.h:208: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/text/StringCommon.h:215: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/text/StringCommon.h:215: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/text/StringCommon.h:215: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/text/StringCommon.h:247: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 3 2015-03-15 22:54:14 PDT
Comment on attachment 248693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248693&action=review r=me. > Source/WTF/ChangeLog:20 > + I moved the low level equal() code form StringImpl to StringCommon ... code FROM StringImple ...
Benjamin Poulain
Comment 4 2015-03-15 23:52:16 PDT
Committed r181525: <http://trac.webkit.org/changeset/181525>
Note You need to log in before you can comment on or make changes to this bug.