Bug 142715

Summary:

CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bfulgham: review+

Description Benjamin Poulain 2015-03-15 17:42:18 PDT

CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen

Comment 1 Benjamin Poulain 2015-03-15 17:51:20 PDT

Created attachment 248693 [details]
Patch

Comment 2 WebKit Commit Bot 2015-03-15 17:54:06 PDT

Attachment 248693 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/text/StringCommon.h:208:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/StringCommon.h:215:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/StringCommon.h:215:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/StringCommon.h:215:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/StringCommon.h:247:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 5 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Brent Fulgham 2015-03-15 22:54:14 PDT

Comment on attachment 248693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248693&action=review

r=me.

> Source/WTF/ChangeLog:20
> +        I moved the low level equal() code form StringImpl to StringCommon

... code FROM StringImple ...

Comment 4 Benjamin Poulain 2015-03-15 23:52:16 PDT

Committed r181525: <http://trac.webkit.org/changeset/181525>