Bug 142701

Summary:

More event handler improvements

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

UI Events

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, buildbot, rniwa, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	andersca: review+, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none

Description Darin Adler 2015-03-14 16:28:15 PDT

More event handler improvements

Comment 1 Darin Adler 2015-03-14 17:24:30 PDT

Created attachment 248659 [details]
Patch

Comment 2 Darin Adler 2015-03-14 20:39:01 PDT

Created attachment 248663 [details]
Patch

Comment 3 Darin Adler 2015-03-14 20:39:38 PDT

Patch was fine on EWS for all platforms except for GTK, because of gobject bindings. I made a small fix that should make gobject bindings work again.

Comment 4 Build Bot 2015-03-14 21:46:55 PDT

Comment on attachment 248663 [details]
Patch

Attachment 248663 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5822022173065216

New failing tests:
fast/dom/event-handler-attributes.html
media/track/regions-webvtt/vtt-region-parser.html
media/track/regions-webvtt/vtt-region-display.html
media/track/regions-webvtt/vtt-region-list.html
media/track/regions-webvtt/vtt-region-dom-layout.html

Comment 5 Build Bot 2015-03-14 21:46:59 PDT

Created attachment 248668 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 6 Build Bot 2015-03-14 21:52:57 PDT

Comment on attachment 248663 [details]
Patch

Attachment 248663 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6107491469361152

New failing tests:
fast/dom/event-handler-attributes.html
media/track/regions-webvtt/vtt-region-parser.html
media/track/regions-webvtt/vtt-region-display.html
media/track/regions-webvtt/vtt-region-list.html
media/track/regions-webvtt/vtt-region-dom-layout.html

Comment 7 Build Bot 2015-03-14 21:53:01 PDT

Created attachment 248670 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 8 Darin Adler 2015-03-15 10:01:06 PDT

Committed r181507: <http://trac.webkit.org/changeset/181507>