Bug 142648

Summary: RenderBlock::imageChange() calling const methods on exit
Product: WebKit Reporter: Adenilson Cavalcanti Silva <savagobr>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Adenilson Cavalcanti Silva
Reported 2015-03-12 17:22:55 PDT
Remove call to const methods at function exit.
Attachments
Patch (1.29 KB, patch)
2015-03-12 17:24 PDT, Adenilson Cavalcanti 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2015-03-12 20:55 PDT, Adenilson Cavalcanti 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adenilson Cavalcanti
Comment 1 2015-03-12 17:24:23 PDT
Created attachment 248556 [details] Patch
Darin Adler
Comment 2 2015-03-12 17:50:05 PDT
Comment on attachment 248556 [details] Patch I suggest remove this override entirely.
Adenilson Cavalcanti Silva
Comment 3 2015-03-12 20:35:17 PDT
Yeah, makes sense. I will upload a new patch doing that.
Adenilson Cavalcanti
Comment 4 2015-03-12 20:55:57 PDT
Created attachment 248565 [details] Patch
Brent Fulgham
Comment 5 2015-03-14 13:04:46 PDT
Comment on attachment 248565 [details] Patch r=me.
WebKit Commit Bot
Comment 6 2015-03-14 13:50:23 PDT
Comment on attachment 248565 [details] Patch Clearing flags on attachment: 248565 Committed r181500: <http://trac.webkit.org/changeset/181500>
WebKit Commit Bot
Comment 7 2015-03-14 13:50:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.