Bug 142638

Summary: Prohibit GC while sweeping
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, kling, mhahnenb
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Description Geoffrey Garen 2015-03-12 13:26:55 PDT 
Prohibit GC while sweeping
Comment 1 Geoffrey Garen 2015-03-12 13:36:39 PDT 
Created attachment 248538 [details]
Patch
Comment 2 Geoffrey Garen 2015-03-12 13:50:53 PDT 
Created attachment 248540 [details]
Patch
Comment 3 Andreas Kling 2015-03-12 15:59:35 PDT 
Comment on attachment 248540 [details]
Patch

This seems entirely reasonable. r=me
Comment 4 Filip Pizlo 2015-03-12 16:02:51 PDT 
Comment on attachment 248540 [details]
Patch

I recommend DeferGCForAWhile, so that if the sweep reports extra cost, then we won't GC as we're popping the DeferGC scope.  I believe in such cases it's always preferable to wait until the allocation itself realizes that it should GC.
Comment 5 Geoffrey Garen 2015-03-12 19:39:51 PDT 
(In reply to comment #4)
> Comment on attachment 248540 [details]
> Patch
> 
> I recommend DeferGCForAWhile, so that if the sweep reports extra cost, then
> we won't GC as we're popping the DeferGC scope.  I believe in such cases
> it's always preferable to wait until the allocation itself realizes that it
> should GC.

OK. Will do.
Comment 6 Geoffrey Garen 2015-03-13 13:15:08 PDT 
Committed r181486: <http://trac.webkit.org/changeset/181486>