Bug 142638

Summary: Prohibit GC while sweeping
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, kling, mhahnenb
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Geoffrey Garen
Reported 2015-03-12 13:26:55 PDT
Prohibit GC while sweeping
Attachments
Patch (3.41 KB, patch)
2015-03-12 13:36 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (3.42 KB, patch)
2015-03-12 13:50 PDT, Geoffrey Garen 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2015-03-12 13:36:39 PDT
Created attachment 248538 [details] Patch
Geoffrey Garen
Comment 2 2015-03-12 13:50:53 PDT
Created attachment 248540 [details] Patch
Andreas Kling
Comment 3 2015-03-12 15:59:35 PDT
Comment on attachment 248540 [details] Patch This seems entirely reasonable. r=me
Filip Pizlo
Comment 4 2015-03-12 16:02:51 PDT
Comment on attachment 248540 [details] Patch I recommend DeferGCForAWhile, so that if the sweep reports extra cost, then we won't GC as we're popping the DeferGC scope. I believe in such cases it's always preferable to wait until the allocation itself realizes that it should GC.
Geoffrey Garen
Comment 5 2015-03-12 19:39:51 PDT
(In reply to comment #4) > Comment on attachment 248540 [details] > Patch > > I recommend DeferGCForAWhile, so that if the sweep reports extra cost, then > we won't GC as we're popping the DeferGC scope. I believe in such cases > it's always preferable to wait until the allocation itself realizes that it > should GC. OK. Will do.
Geoffrey Garen
Comment 6 2015-03-13 13:15:08 PDT
Committed r181486: <http://trac.webkit.org/changeset/181486>
Note You need to log in before you can comment on or make changes to this bug.