Bug 142630

Summary: [Mavericks] Test snapshots are 1600x1200 on Retina devices
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=139884
https://bugs.webkit.org/show_bug.cgi?id=142258
https://bugs.webkit.org/show_bug.cgi?id=142632
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2015-03-12 11:56:55 PDT
Looks like the fix from bug 139884 are actually needed on Mavericks too. I previously limited it to newer OS versions, because it seemed like Mavericks was not affected, but it is. For example, fast/css/object-fit/object-fit-canvas.html gets 1600x1200 results, and actually non-matching ones.
Attachments
proposed fix (1.43 KB, patch)
2015-03-12 12:00 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-03-12 12:00:20 PDT
Created attachment 248529 [details] proposed fix
WebKit Commit Bot
Comment 2 2015-03-12 13:24:47 PDT
Comment on attachment 248529 [details] proposed fix Clearing flags on attachment: 248529 Committed r181451: <http://trac.webkit.org/changeset/181451>
WebKit Commit Bot
Comment 3 2015-03-12 13:24:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.