Bug 142576

Summary:

[GTK] Add support for handling TLS errors to MiniBrowser

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, commit-queue, gustavo, pnormand, zan

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fix coding style issues	svillar: review+

Description Carlos Garcia Campos 2015-03-11 04:51:32 PDT

It's useful for testing TLS errors handling itself, but also to allow ignoring TLS errors when testing.

Comment 1 Carlos Garcia Campos 2015-03-11 04:52:53 PDT

Created attachment 248412 [details]
Patch

Comment 2 WebKit Commit Bot 2015-03-11 04:55:37 PDT

Attachment 248412 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:374:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:375:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:376:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:377:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Carlos Garcia Campos 2015-03-11 04:57:12 PDT

Created attachment 248413 [details]
Fix coding style issues

Comment 4 Sergio Villar Senin 2015-03-11 07:44:18 PDT

Comment on attachment 248413 [details]
Fix coding style issues

View in context: https://bugs.webkit.org/attachment.cgi?id=248413&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:374
> +        GTK_MESSAGE_QUESTION, GTK_BUTTONS_YES_NO, "%s", "Unacceptable TLS Certificate");

/Unacceptable/Invalid/ ?

Comment 5 Carlos Alberto Lopez Perez 2015-03-11 08:58:34 PDT

BTW.

I think we also need a switch to completely disable certificate validation. Otherwise URLs that embed content from sites with invalid certs don't work.

Example: http://people.igalia.com/clopez/testssl.html

Comment 6 Carlos Garcia Campos 2015-03-11 12:14:56 PDT

Committed r181399: <http://trac.webkit.org/changeset/181399>