Bug 142566

Summary: Class constructor should throw TypeError when "called"
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: JavaScriptCoreAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, buildbot, commit-queue, fpizlo, ggaren, mark.lam, rniwa, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140491    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews101 for mac-mavericks
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
Skipped the test
none
Don't enable ES6 by deafult none

Description Ryosuke Niwa 2015-03-10 21:55:56 PDT 
ES6 disallows the constructor of a class to be involved with [[Call]] semantics.
Comment 1 Ryosuke Niwa 2015-03-13 01:46:40 PDT 
Created attachment 248580 [details]
Patch
Comment 2 Build Bot 2015-03-13 02:41:31 PDT 
Comment on attachment 248580 [details]
Patch

Attachment 248580 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6121258450157568

New failing tests:
js/class-syntax-call.html
Comment 3 Build Bot 2015-03-13 02:41:35 PDT 
Created attachment 248581 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-03-13 02:49:25 PDT 
Comment on attachment 248580 [details]
Patch

Attachment 248580 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5378845972627456

New failing tests:
js/class-syntax-call.html
Comment 5 Build Bot 2015-03-13 02:49:28 PDT 
Created attachment 248583 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Ryosuke Niwa 2015-03-13 13:04:02 PDT 
Created attachment 248600 [details]
Skipped the test
Comment 7 Michael Saboff 2015-03-13 13:27:49 PDT 
Comment on attachment 248600 [details]
Skipped the test

You enable the ES6 class syntax feature, but the tests are disabled.  Seems like these should match.
Comment 8 Ryosuke Niwa 2015-03-13 13:51:47 PDT 
(In reply to comment #7)
> Comment on attachment 248600 [details]
> Skipped the test
> 
> You enable the ES6 class syntax feature, but the tests are disabled.  Seems
> like these should match.

Oh oops, that was supposed to be excluded. Let me re-upload the patch.
Comment 9 Ryosuke Niwa 2015-03-13 13:55:44 PDT 
Created attachment 248606 [details]
Don't enable ES6 by deafult
Comment 10 Michael Saboff 2015-03-13 14:48:13 PDT 
Comment on attachment 248606 [details]
Don't enable ES6 by deafult

r=me
Comment 11 Ryosuke Niwa 2015-03-13 15:15:44 PDT 
Comment on attachment 248606 [details]
Don't enable ES6 by deafult

Thanks for the review!
Comment 12 WebKit Commit Bot 2015-03-13 16:02:24 PDT 
Comment on attachment 248606 [details]
Don't enable ES6 by deafult

Clearing flags on attachment: 248606

Committed r181490: <http://trac.webkit.org/changeset/181490>
Comment 13 WebKit Commit Bot 2015-03-13 16:02:32 PDT 
All reviewed patches have been landed.  Closing bug.