Bug 142559

Summary: Inline block children do not have correct baselines if their children are also block elements
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Myles C. Maxfield 2015-03-10 19:27:55 PDT 
Inline block children do not have correct baselines if their children are also block elements
Comment 1 Myles C. Maxfield 2015-03-10 19:29:08 PDT 
Created attachment 248387 [details]
Patch
Comment 2 Darin Adler 2015-03-10 22:53:39 PDT 
Comment on attachment 248387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248387&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:3023
> +            const FontMetrics& fontMetrics = firstLineStyle().fontMetrics();

Maybe auto& here?

> Source/WebCore/rendering/RenderBlockFlow.cpp:3033
> +            const RenderStyle& style = isFirstLine ? firstLineStyle() : this->style();

Maybe auto& here?
Comment 3 Myles C. Maxfield 2015-03-11 07:40:34 PDT 
Comment on attachment 248387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248387&action=review

>> Source/WebCore/rendering/RenderBlockFlow.cpp:3023
>> +            const FontMetrics& fontMetrics = firstLineStyle().fontMetrics();
> 
> Maybe auto& here?

Done.

>> Source/WebCore/rendering/RenderBlockFlow.cpp:3033
>> +            const RenderStyle& style = isFirstLine ? firstLineStyle() : this->style();
> 
> Maybe auto& here?

Done.
Comment 4 Myles C. Maxfield 2015-03-11 07:41:30 PDT 
Committed r181387: <http://trac.webkit.org/changeset/181387>