Bug 142559

Summary: Inline block children do not have correct baselines if their children are also block elements
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Myles C. Maxfield
Reported 2015-03-10 19:27:55 PDT
Inline block children do not have correct baselines if their children are also block elements
Attachments
Patch (5.83 KB, patch)
2015-03-10 19:29 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-03-10 19:29:08 PDT
Created attachment 248387 [details] Patch
Darin Adler
Comment 2 2015-03-10 22:53:39 PDT
Comment on attachment 248387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248387&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:3023 > + const FontMetrics& fontMetrics = firstLineStyle().fontMetrics(); Maybe auto& here? > Source/WebCore/rendering/RenderBlockFlow.cpp:3033 > + const RenderStyle& style = isFirstLine ? firstLineStyle() : this->style(); Maybe auto& here?
Myles C. Maxfield
Comment 3 2015-03-11 07:40:34 PDT
Comment on attachment 248387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248387&action=review >> Source/WebCore/rendering/RenderBlockFlow.cpp:3023 >> + const FontMetrics& fontMetrics = firstLineStyle().fontMetrics(); > > Maybe auto& here? Done. >> Source/WebCore/rendering/RenderBlockFlow.cpp:3033 >> + const RenderStyle& style = isFirstLine ? firstLineStyle() : this->style(); > > Maybe auto& here? Done.
Myles C. Maxfield
Comment 4 2015-03-11 07:41:30 PDT
Committed r181387: <http://trac.webkit.org/changeset/181387>
Note You need to log in before you can comment on or make changes to this bug.