Bug 142539

Summary: Use std::numeric_limits<unsigned>::max() instead of (unsigned)-1
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. none

Mark Lam
Reported 2015-03-10 12:22:20 PDT
There is some residual code that is still using (unsigned)-1 to express std::numeric_limits<unsigned>::max(). We should fix them.
Attachments
the patch. (9.45 KB, patch)
2015-03-10 12:26 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-03-10 12:26:52 PDT
Created attachment 248346 [details] the patch.
WebKit Commit Bot
Comment 2 2015-03-10 13:18:53 PDT
Comment on attachment 248346 [details] the patch. Clearing flags on attachment: 248346 Committed r181343: <http://trac.webkit.org/changeset/181343>
WebKit Commit Bot
Comment 3 2015-03-10 13:18:56 PDT
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 4 2015-03-12 16:51:51 PDT
Why not use UINT_MAX? That's much clearer.
Mark Lam
Comment 5 2015-03-12 17:02:18 PDT
(In reply to comment #4) > Why not use UINT_MAX? That's much clearer. I was misled by http://www.cplusplus.com/reference/climits/ which that UINT_MAX is 16 bit. I see from http://en.cppreference.com/w/cpp/types/climits that I was wrong. If you feel strongly about it, I can switch all the sites to UINT_MAX.
Note You need to log in before you can comment on or make changes to this bug.