Summary: | Use std::numeric_limits<unsigned>::max() instead of (unsigned)-1 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2015-03-10 12:22:20 PDT
Created attachment 248346 [details]
the patch.
Comment on attachment 248346 [details] the patch. Clearing flags on attachment: 248346 Committed r181343: <http://trac.webkit.org/changeset/181343> All reviewed patches have been landed. Closing bug. Why not use UINT_MAX? That's much clearer. (In reply to comment #4) > Why not use UINT_MAX? That's much clearer. I was misled by http://www.cplusplus.com/reference/climits/ which that UINT_MAX is 16 bit. I see from http://en.cppreference.com/w/cpp/types/climits that I was wrong. If you feel strongly about it, I can switch all the sites to UINT_MAX. |