|Summary:||Use std::numeric_limits<unsigned>::max() instead of (unsigned)-1|
|Product:||WebKit||Reporter:||Mark Lam <mark.lam>|
|Version:||528+ (Nightly build)|
Description Mark Lam 2015-03-10 12:22:20 PDT
There is some residual code that is still using (unsigned)-1 to express std::numeric_limits<unsigned>::max(). We should fix them.
Comment 2 WebKit Commit Bot 2015-03-10 13:18:53 PDT
Comment on attachment 248346 [details] the patch. Clearing flags on attachment: 248346 Committed r181343: <http://trac.webkit.org/changeset/181343>
Comment 3 WebKit Commit Bot 2015-03-10 13:18:56 PDT
All reviewed patches have been landed. Closing bug.
Comment 4 Filip Pizlo 2015-03-12 16:51:51 PDT
Why not use UINT_MAX? That's much clearer.
Comment 5 Mark Lam 2015-03-12 17:02:18 PDT
(In reply to comment #4) > Why not use UINT_MAX? That's much clearer. I was misled by http://www.cplusplus.com/reference/climits/ which that UINT_MAX is 16 bit. I see from http://en.cppreference.com/w/cpp/types/climits that I was wrong. If you feel strongly about it, I can switch all the sites to UINT_MAX.