[GStreamer][GTK] Minimum required version for gst-plugins-base is actually 1.1

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

When finding the GStreamer libraries at Source/cmake/FindGStreamer.cmake the minimum required version for gst-plugins-base is 1.0.

However the file Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp includes <gst/app/app.h> which is only available on gst-plugins-base >= 1.1

This include was added on r177085 <http://trac.webkit.org/r177085>

So I guess we either need to raise the minimum version required or put some ifdefs.

[Sebastian Dröge (slomo)]

I'll provide a patch tomorrow to make it work again with 1.0

[Sebastian Dröge (slomo)]

Actually no, we include 1.2+ headers in various places unconditionally. I would recommend to just do it consistently and then require GStreamer >= 1.2.0.

Opinions?

I can prepare a patch for cleaning up the includes and the dependency check.

[Carlos Garcia Campos]

(In reply to comment #2)
> Actually no, we include 1.2+ headers in various places unconditionally. I
> would recommend to just do it consistently and then require GStreamer >=
> 1.2.0.
> 
> Opinions?
> 
> I can prepare a patch for cleaning up the includes and the dependency check.

We have a policy of not bumping minimum requirements unless it's really needed (or until we break the ABI), so we should make sure it build with 1.0.3, see http://trac.webkit.org/wiki/WebKitGTK/Dependencies

[Sebastian Dröge (slomo)]

Ok, I can make a patch but I can't really test it. I have no 1.0.x anywhere anymore. So better if someone else does that

[Carlos Alberto Lopez Perez]

(In reply to comment #4)
> Ok, I can make a patch but I can't really test it. I have no 1.0.x anywhere
> anymore. So better if someone else does that

I have a development environment with 1.0.9, I can test the patch with that version.

[Sebastian Dröge (slomo)]

Awesome, I'll prepare one later today then and make sure it builds with 1.4 at least :) Thanks!

[Sebastian Dröge (slomo)]

Created attachment 248512 [details]
Patch

[Sebastian Dröge (slomo)]

Please check if this indeed compiles with 1.0 or if anything else is missing. If it fails please paste the compiler errors here :)

It builds at least on 1.4.5 with these changes.

[Carlos Alberto Lopez Perez]

I tested it, and it builds fine with 1.0.9. Thanks!

[Philippe Normand]

Comment on attachment 248512 [details]
Patch

Ok let's land this then :)

[WebKit Commit Bot]

Comment on attachment 248512 [details]
Patch

Clearing flags on attachment: 248512

Committed r181449: <http://trac.webkit.org/changeset/181449>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.