Bug 142501

Summary:

scroll-snap-points do not work very well with mechanical scroll wheel events

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Layout and Rendering

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch	none

Description Brent Fulgham 2015-03-09 11:49:08 PDT

Although scroll-snap-points work nicely with momentum-capable gestures, older mechanical wheel (or roller ball) pointing devices do not seem to reliably trigger the snap animation. This needs to be corrected.

Comment 1 Radar WebKit Bug Importer 2015-03-09 11:49:44 PDT

<rdar://problem/20093511>

Comment 2 Brent Fulgham 2015-03-09 12:09:42 PDT

The problem is that we trigger the animation on the "scroll end" phase, which we never receive for mechanical wheels. This is similar to the difficulty in scroll latching.

We may need to create some kind of wheel event metric that trigger the animation event if a sufficient amount of time passes from the last wheel event.

Comment 3 Wenson Hsieh 2015-06-28 18:04:55 PDT

Created attachment 255734 [details]
Patch

Comment 4 Brent Fulgham 2015-06-30 18:01:26 PDT

Comment on attachment 255734 [details]
Patch

I think this looks good. r=me.

Comment 5 WebKit Commit Bot 2015-06-30 18:52:13 PDT

Comment on attachment 255734 [details]
Patch

Clearing flags on attachment: 255734

Committed r186160: <http://trac.webkit.org/changeset/186160>

Comment 6 WebKit Commit Bot 2015-06-30 18:52:16 PDT

All reviewed patches have been landed.  Closing bug.