Summary: | 5 tests fail on Apple Mac WK2 performance bots | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, cdumez, commit-queue, rniwa, sam, slewis | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2015-03-09 04:47:54 PDT
The tests are actually working fine but we print a warning on stderr and that causes the tests to be marked as failing. We should silence this warning or not fail for this type of warning. The reason it fails to create a sandbox extension is because these files do not exist. Arguably, we should probably not try to create extensions for non-existing files. Created attachment 248388 [details]
Patch
Comment on attachment 248388 [details] Patch Clearing flags on attachment: 248388 Committed r181363: <http://trac.webkit.org/changeset/181363> All reviewed patches have been landed. Closing bug. This logging was meant to help investigating bugs like rdar://problem/18921253, rdar://problem/18731910, rdar://problem/17766373, rdar://problem/10156710 and related. But given that I didn't put it to good use in two years, it seems acceptable to remove this release mode logging. |