[GTK] Layout Test http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html is failing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Marcos Chavarría Teijeiro (irc: chavaone)]

The http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html layout test is failing on GTK+ since r181134 (https://trac.webkit.org/changeset/r181134).

The diff is the following:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-actual.txt
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html displayed insecure content from http://127.0.0.1:8080/resources/test.mp4.
+CONSOLE MESSAGE: [blocked] The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html was not allowed to display insecure content from http://127.0.0.1:8080/resources/test.mp4.
 
-CONSOLE MESSAGE: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html displayed insecure content from http://127.0.0.1:8080/resources/test.mp4.
+CONSOLE MESSAGE: [blocked] The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html was not allowed to display insecure content from http://127.0.0.1:8080/resources/test.mp4.
 
 This test opens a window that loads insecure HTML5 audio and video. We should trigger a mixed content callback because the main frame in the window is HTTPS but is displaying insecure content.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 319172 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 319172 [details]
Patch

Clearing flags on attachment: 319172

Committed r221237: <http://trac.webkit.org/changeset/221237>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34108248>

[Michael Catanzaro]

Good find, thanks!

In this case, the global expectation is outdated because the console message changed, but the test result never got updated because the test has been failing on macOS this whole time. So we should update the global expectation instead of adding a platform-specific one. I'll handle it.