Bug 142460

Summary: BuiltinExecutables keeps finalized Weaks around, pinning WeakBlocks.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ggaren, kling
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2015-03-08 13:38:19 PDT
I'm seeing a bunch of WeakBlocks that are only kept alive by the UnlinkedFunctionExecutable Weak pointers in VM::builtinExecutables().
Attachments
Patch (3.32 KB, patch)
2015-03-08 13:42 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-03-08 13:42:20 PDT
Created attachment 248201 [details] Patch
Geoffrey Garen
Comment 2 2015-03-08 15:46:31 PDT
Comment on attachment 248201 [details] Patch r=me I'll give you a dollar if you write the patch that says that a WeakBlock with only nulls should not pin down a MarkedBlock.
Andreas Kling
Comment 3 2015-03-08 16:40:48 PDT
(In reply to comment #2) > Comment on attachment 248201 [details] > Patch > > r=me > > I'll give you a dollar if you write the patch that says that a WeakBlock > with only nulls should not pin down a MarkedBlock. You're on!
WebKit Commit Bot
Comment 4 2015-03-08 16:47:52 PDT
Comment on attachment 248201 [details] Patch Clearing flags on attachment: 248201 Committed r181248: <http://trac.webkit.org/changeset/181248>
WebKit Commit Bot
Comment 5 2015-03-08 16:47:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.