Summary: | JITThunks keeps finalized Weaks around, pinning WeakBlocks. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | JavaScriptCore | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ggaren, kling | ||||
Priority: | P2 | Keywords: | Performance | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2015-03-08 04:20:28 PDT
Created attachment 248188 [details]
Proposed patch
Comment on attachment 248188 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=248188&action=review > Source/JavaScriptCore/jit/JITThunks.cpp:81 > + NativeExecutable* nativeExecutable = jsCast<NativeExecutable*>(handle.get().asCell()); I would use auto* here instead of NativeExecutable* here since the type is already named over on the right side of the line. Maybe use a reference here since this can’t be null? > Source/JavaScriptCore/jit/JITThunks.h:48 > +class JITThunks final : public WeakHandleOwner { How about using private inheritance instead of public? The new code seems to be all inside JITThunks member functions. Committed <https://trac.webkit.org/r181250> |