Summary: | DumpRenderTree and WebKitTestRunner should rename WorkQueue to something that will not be confused with WTF::WorkQueue | ||
---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | andersca, bfulgham, koivisto, sam |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All |
Description
Brent Fulgham
2015-03-07 20:23:47 PST
The WorkQueue classes in DRT and WKTR are not threading primitives like WTF::WorkQueue, but rather just a plain old queue of things to do (it's actually quite similar to WTF::MessageQueue). Having the same name does complicate things here, I admit. Are they really similar enough to WTF::WorkQueue that we could just use it? (In reply to comment #2) > Are they really similar enough to WTF::WorkQueue that we could just use it? Maybe not. I notice the DRT/WKTR version has the concept of being "frozen", which seems to mean "ignore any passed dispatch functions". I'm not sure we would want that "feature" to be part of the WTF::WorkQueue implementation, so maybe we should just leave things as-is. (In reply to comment #3) > (In reply to comment #2) > > Are they really similar enough to WTF::WorkQueue that we could just use it? > > Maybe not. I notice the DRT/WKTR version has the concept of being "frozen", > which seems to mean "ignore any passed dispatch functions". I'm not sure we > would want that "feature" to be part of the WTF::WorkQueue implementation, > so maybe we should just leave things as-is. We should probably just mutate this bug into renaming the DRT/WKTR classes. I have not good ideas for names. |