Bug 142448
| Summary: | DumpRenderTree and WebKitTestRunner should rename WorkQueue to something that will not be confused with WTF::WorkQueue | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | andersca, bfulgham, koivisto, sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Brent Fulgham
For historical reasons, DumpRenderTree and WebKitTestRunner have their own WorkQueue implementations. Now that WorkQueue lives in WTF, we should merge these disparate implementations and standardize on one implementation. This will simplify the code, as well as increasing the test coverage for this functionality.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
The WorkQueue classes in DRT and WKTR are not threading primitives like WTF::WorkQueue, but rather just a plain old queue of things to do (it's actually quite similar to WTF::MessageQueue). Having the same name does complicate things here, I admit.
Anders Carlsson
Are they really similar enough to WTF::WorkQueue that we could just use it?
Brent Fulgham
(In reply to comment #2)
> Are they really similar enough to WTF::WorkQueue that we could just use it?
Maybe not. I notice the DRT/WKTR version has the concept of being "frozen", which seems to mean "ignore any passed dispatch functions". I'm not sure we would want that "feature" to be part of the WTF::WorkQueue implementation, so maybe we should just leave things as-is.
Sam Weinig
(In reply to comment #3)
> (In reply to comment #2)
> > Are they really similar enough to WTF::WorkQueue that we could just use it?
>
> Maybe not. I notice the DRT/WKTR version has the concept of being "frozen",
> which seems to mean "ignore any passed dispatch functions". I'm not sure we
> would want that "feature" to be part of the WTF::WorkQueue implementation,
> so maybe we should just leave things as-is.
We should probably just mutate this bug into renaming the DRT/WKTR classes. I have not good ideas for names.