| Summary: | The code to link FunctionExecutable is duplicated everywhere | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
| Component: | JavaScriptCore | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | barraclough, benjamin, fpizlo, ggaren, mark.lam, msaboff, oliver | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 142388 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ryosuke Niwa
2015-03-07 01:18:02 PST
Created attachment 248150 [details]
Patch
Created attachment 248151 [details]
Fixed the bug title
Created attachment 248152 [details]
Cleanup
Comment on attachment 248152 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=248152&action=review > Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:144 > + // The unlinkedBodyEndColumn is based-0. Hence, we need to add 1 to it. But if the The term is "0-based", not "based-0". Would be nice to fix this since you are moving this comment into a new function. Comment on attachment 248152 [details]
Cleanup
Thanks for doing this!
(In reply to comment #4) > Comment on attachment 248152 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248152&action=review > > > Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:144 > > + // The unlinkedBodyEndColumn is based-0. Hence, we need to add 1 to it. But if the > > The term is "0-based", not "based-0". Would be nice to fix this since you > are moving this comment into a new function. Thanks for the review. Will fix! Committed r181213: <http://trac.webkit.org/changeset/181213> |