Bug 142420

Summary: Web Inspector: ES6: Improved Support for Iterator Objects
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Iterator Previews
none
[IMAGE] Iterator Internal Properties
none
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-03-06 17:43:27 PST
* SUMMARY
ES6: Improved Console Support for Iterator Objects.

For iterators, it is useful to see previews of the next few objects in the iterator.

  js> var iter = "long string"[Symbol.iterator]()
  <-  StringIterator ["l", "o", "n", "g", " ", ...]

  js> iter.next(); iter.next(); iter
  <-  StringIterator ["n", "g", " ", "s", "t", ...]

And also Internal Properties, such as the object being iterating and for some iterators the Kind of Iterator ("key", "value", "key+value").
Comment 1 Radar WebKit Bug Importer 2015-03-06 17:43:42 PST
<rdar://problem/20080363>
Comment 2 Joseph Pecoraro 2015-03-06 17:50:03 PST
Created attachment 248121 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2015-03-06 17:50:28 PST
Created attachment 248122 [details]
[IMAGE] Iterator Previews
Comment 4 Joseph Pecoraro 2015-03-06 17:51:00 PST
Created attachment 248124 [details]
[IMAGE] Iterator Internal Properties
Comment 5 WebKit Commit Bot 2015-03-06 17:53:08 PST
Attachment 248121 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:424:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:432:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Joseph Pecoraro 2015-03-06 18:32:55 PST
Created attachment 248129 [details]
[PATCH] Proposed Fix
Comment 7 WebKit Commit Bot 2015-03-06 20:03:19 PST
Comment on attachment 248129 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 248129

Committed r181203: <http://trac.webkit.org/changeset/181203>
Comment 8 WebKit Commit Bot 2015-03-06 20:03:24 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Joseph Pecoraro 2015-03-09 20:23:09 PDT
*** Bug 141041 has been marked as a duplicate of this bug. ***