Summary: | SVG <image> with height or width less than 1 fails to render image | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jean-Pierre Fiset <bugzilla> | ||||||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ahayes, bugzilla | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 523.x (Safari 3) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.4 | ||||||||||||
Attachments: |
|
Description
Jean-Pierre Fiset
2007-06-20 12:58:37 PDT
Created attachment 15142 [details]
external image
Created attachment 15143 [details]
Test Case
Created attachment 15192 [details]
First attempt
This is a bit of a hack, but I guess it just can't work using Length.
Cheers,
Rob.
Comment on attachment 15192 [details]
First attempt
You use "2." in some places, I'd prefer "2.0" or "2.0f" as appropriate.
Also, this asks for info directly from the element at paint time - I don't think that's right. Such things should be determined at layout time if needed.
Created attachment 15268 [details]
Addressing the current issues
This patch keeps around 2 float member vars for svg image width/height to work around the int based layout system. Note that now the values are determined at layout time (calcWidth/calcHeight).
Cheers,
Rob.
Comment on attachment 15268 [details]
Addressing the current issues
r=me
Comment on attachment 15268 [details]
Addressing the current issues
r=me
|