Bug 142409

Summary:

Web Inspector: Adopt Object Literal Method Property Syntax

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, burg, graouts, joepeck, jonowells, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	timothy: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Archive of layout-test-results from ews101 for mac-mavericks	none

Description Joseph Pecoraro 2015-03-06 13:52:17 PST

* SUMMARY
Adopt Object Literal Method Property Syntax.

Instead of whole-sale adoption, I'm going to start with the copyright 2015 files I've recently edited (Console stuff). This will be a good test bed.

Comment 1 Joseph Pecoraro 2015-03-06 13:53:25 PST

Created attachment 248096 [details]
[PATCH] Proposed Fix

Comment 2 Timothy Hatcher 2015-03-06 13:56:40 PST

Comment on attachment 248096 [details]
[PATCH] Proposed Fix

Awesome!

Comment 3 Build Bot 2015-03-06 14:20:42 PST

Comment on attachment 248096 [details]
[PATCH] Proposed Fix

Attachment 248096 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4636303169683456

New failing tests:
inspector/model/parse-script-syntax-tree.html
inspector/css/matched-style-properties.html
inspector/protocol-promise-result.html
inspector/event-listener.html
inspector/test-harness-trivially-works.html
inspector/css/pseudo-element-matches.html
inspector/css/selector-specificity.html
inspector/event-listener-set.html

Comment 4 Build Bot 2015-03-06 14:20:46 PST

Created attachment 248100 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 5 Build Bot 2015-03-06 14:28:42 PST

Comment on attachment 248096 [details]
[PATCH] Proposed Fix

Attachment 248096 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6746358325182464

New failing tests:
inspector/model/parse-script-syntax-tree.html
inspector/css/matched-style-properties.html
inspector/protocol-promise-result.html
inspector/event-listener.html
inspector/test-harness-trivially-works.html
inspector/css/pseudo-element-matches.html
inspector/css/selector-specificity.html
inspector/event-listener-set.html

Comment 6 Build Bot 2015-03-06 14:28:46 PST

Created attachment 248101 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 7 Joseph Pecoraro 2015-03-06 14:47:55 PST

<http://trac.webkit.org/changeset/181186>