Bug 142409

Summary:

Web Inspector: Adopt Object Literal Method Property Syntax

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, burg, graouts, joepeck, jonowells, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	timothy: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Archive of layout-test-results from ews101 for mac-mavericks	none

Joseph Pecoraro

Reported 2015-03-06 13:52:17 PST

* SUMMARY Adopt Object Literal Method Property Syntax. Instead of whole-sale adoption, I'm going to start with the copyright 2015 files I've recently edited (Console stuff). This will be a good test bed.

Attachments
[PATCH] Proposed Fix (23.28 KB, patch) 2015-03-06 13:53 PST, Joseph Pecoraro	timothy: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (783.88 KB, application/zip) 2015-03-06 14:20 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-mavericks (653.97 KB, application/zip) 2015-03-06 14:28 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2015-03-06 13:53:25 PST

Created attachment 248096 [details] [PATCH] Proposed Fix

Timothy Hatcher

Comment 2 2015-03-06 13:56:40 PST

Comment on attachment 248096 [details] [PATCH] Proposed Fix Awesome!

Build Bot

Comment 3 2015-03-06 14:20:42 PST

Comment on attachment 248096 [details] [PATCH] Proposed Fix Attachment 248096 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4636303169683456 New failing tests: inspector/model/parse-script-syntax-tree.html inspector/css/matched-style-properties.html inspector/protocol-promise-result.html inspector/event-listener.html inspector/test-harness-trivially-works.html inspector/css/pseudo-element-matches.html inspector/css/selector-specificity.html inspector/event-listener-set.html

Build Bot

Comment 4 2015-03-06 14:20:46 PST

Created attachment 248100 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-03-06 14:28:42 PST

Comment on attachment 248096 [details] [PATCH] Proposed Fix Attachment 248096 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6746358325182464 New failing tests: inspector/model/parse-script-syntax-tree.html inspector/css/matched-style-properties.html inspector/protocol-promise-result.html inspector/event-listener.html inspector/test-harness-trivially-works.html inspector/css/pseudo-element-matches.html inspector/css/selector-specificity.html inspector/event-listener-set.html

Build Bot

Comment 6 2015-03-06 14:28:46 PST

Created attachment 248101 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Joseph Pecoraro

Comment 7 2015-03-06 14:47:55 PST

<http://trac.webkit.org/changeset/181186>

Note You need to log in before you can comment on or make changes to this bug.