Move dispatch_data use behind NetworkCache::Data abstraction

• Component: Page Loading
• Status: RESOLVED FIXED

[Antti Koivisto]

Less platform dependent code

[Antti Koivisto]

Created attachment 248059 [details]
patch

[WebKit Commit Bot]

Attachment 248059 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:66:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 248060 [details]
patch

[WebKit Commit Bot]

Attachment 248060 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:67:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 248060 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248060&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:113
> +    void apply(std::function<bool (const uint8_t*, size_t)>&&) const;

I think the function can be const& here.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:70
> +    if (!m_size)
> +        return;

It's a little weird that calling apply on an empty Data results in nothing happening.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:264
> +    Vector<uint8_t, 4096> filler(dataOffset - headerData.size(), 0);

I'd use an std::array here instead.

[Antti Koivisto]

https://trac.webkit.org/r181160