Remove willDestroyFrame in WKBundlePageLoaderClient

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

I added willDestroyFrame in r154540 but I realized recently (see bug #141641) that it has never actually worked :-( Adding the callback to WKBundlePageLoaderClient was the first mistake, since frames are handled by WebProcess and DidDestroyFrame message is indeed a WebProcessProxy not a WebPageProxyProxy one. Second mistake was calling the callback from WebFrameLoaderClient::frameLoaderDestroyed(), since at that point the frame has already been detached from the page and so WebFrame::page() always returns nullptr. So this in fact dead code. And since r180211 nobody is using it. 
My first idea was to deprecate the method and remove the dead code, but since there aren't any new versions of WKBundlePageLoaderClient, and I guess nobody apart from WebKit internally is using it, maybe we can just remove it?

[Carlos Garcia Campos]

I'll make it unavailable as suggested by Anders on IRC

[Carlos Garcia Campos]

Created attachment 248147 [details]
Patch

[Carlos Garcia Campos]

Committed r181222: <http://trac.webkit.org/changeset/181222>