Bug 142385

Summary: [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pnormand, svillar, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Carlos Garcia Campos
Reported 2015-03-05 23:34:29 PST
This is because I'm using GMainLoopSource created on the heap and destroyed automatically when reached for the timeout. We should use stack allocated one that will be cancelled when current scope is destroyed.
Attachments
Patch (1.90 KB, patch)
2015-03-05 23:36 PST, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-03-05 23:34:58 PST
TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources... (pid=20904) /webkit2/WebKitWebView/resources: OK /webkit2/WebKitWebView/history-cache: OK /webkit2/WebKitWebView/sync-request-on-max-conns: OK /webkit2/WebKitWebResource/loading: OK /webkit2/WebKitWebResource/response: OK /webkit2/WebKitWebResource/mime-type: OK /webkit2/WebKitWebResource/suggested-filename: OK /webkit2/WebKitWebResource/active-uri: OK /webkit2/WebKitWebResource/get-data: OK /webkit2/WebKitWebPage/send-request: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:709:testWebViewSyncRequestOnMaxConns(SyncRequestOnMaxConnsTest*, gconstpointer)::__lambda2: code should not be reached FAIL GTester: last random seed: R02S24f485eab1e5cd6f16d591e4d82f8a9d (pid=21130) FAIL: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources
Carlos Garcia Campos
Comment 2 2015-03-05 23:36:53 PST
Created attachment 248044 [details] Patch
WebKit Commit Bot
Comment 3 2015-03-05 23:38:59 PST
Attachment 248044 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:710: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:713: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 4 2015-03-06 09:21:43 PST
Committed r181159: <http://trac.webkit.org/changeset/181159>
Note You need to log in before you can comment on or make changes to this bug.