Summary: | [S60]: Scrolling support for plugins TSWID: PKII-73JGPV | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mahesh Kulkarni <maheshk> | ||||||||||||||||||
Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||
Status: | CLOSED FIXED | ||||||||||||||||||||
Severity: | Major | CC: | Sachin.Padma | ||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||
Version: | 523.x (Safari 3) | ||||||||||||||||||||
Hardware: | S60 Hardware | ||||||||||||||||||||
OS: | S60 3rd edition | ||||||||||||||||||||
URL: | http://youtube.com/watch?v=zWDgzMojV98&feature=dir | ||||||||||||||||||||
Attachments: |
|
Description
Mahesh Kulkarni
2007-06-20 06:39:23 PDT
Created attachment 15138 [details]
Scroll support for plugin
As discussed,
1) Added NPPVariable variable NPPVPluginFocusPosition
2) Added two MPluginNotifier EPluginActivated and EPluginDeactivated
3) Added memeber function MoveWindow in CPluginWin class
When plugin is activated browser cursor will be hidden. Plugin updates browser with new position whenever it wants to move window. Browser takes offset value, updates its own cursor position (cursor hidden) and scrolls.
Comment on attachment 15138 [details]
Scroll support for plugin
patch does not apply. Please recheck the patch and create with latest codebase.
Created attachment 15216 [details]
Patch with lates tcode
Created patch with latest svn code
Comment on attachment 15216 [details]
Patch with lates tcode
Is this patch for 3.1 or ccb. Please specify. This patch does not apply in ccb. If 3.1 is it branch approved?
Created attachment 15458 [details]
3.1 patch - Scroll support for plugins
Branch approved for this TSW Error
Created attachment 15459 [details]
CCB patch - scroll support
Scroll support for CCB. Details of modifications are specified in above comments.
Comment on attachment 15458 [details]
3.1 patch - Scroll support for plugins
enum should always be added to the end. check npapi.h. What position is being substracted in ProcessEventL when position is being passed to plugin
Created attachment 15699 [details]
3.1 patch - scroll support
In ProcessEventL, EEventActivate event sends the initial position where plugin should display its own cursor and also to handle click event to plugin. To give relative cursor position to plugin, subtracting current cursor position minus plugin start position. In which case plugin will get exact position where plugin is been clicked.
Created attachment 15700 [details]
CCB patch - Scroll support
Enums inserted at the end. There is one custom NPP variable already in CCB, adding new enum after that. For easy maintenances, starting custom NPP variable from 100 which can go up to 1000 according to NPP variable struct.
Comment on attachment 15699 [details]
3.1 patch - scroll support
Changing the value of existing enum will break BC.
Comment on attachment 15699 [details]
3.1 patch - scroll support
This does not modify any existing enum values. above Comments doesn't go with this patch. Resubmitting review request.
Created attachment 15742 [details]
CCB patch - After modifying enum value
Changed existing enum value to old value.
Comment on attachment 15742 [details]
CCB patch - After modifying enum value
Cannot change the values of previous entries in enum. Will break BC. Please fix this and then ask for review.
Comment on attachment 15699 [details]
3.1 patch - scroll support
Typo mistake. Rectified.
Created attachment 15804 [details]
CCB patch
Typo mistake. Rectified.
Comment on attachment 15699 [details]
3.1 patch - scroll support
r=me
Comment on attachment 15804 [details]
CCB patch
r=me
Bulk closing of all s60 platform bugs. Sorry for the noise! |