Bug 14238 – [S60]: Scrolling support for plugins TSWID: PKII-73JGPV

• Component: Plug-ins
• Status: CLOSED FIXED

[Mahesh Kulkarni]

Please specify the following information:

Playing youtube.com video gives bad user experience when browser opens web page containing video and when plugin is activated 

- Use case:


- Steps to reproduce:
1. flash the aalto with web video aalto image
2. install Flash Lite 3 sis on the phone
3. open the browser and go to youtube.com
4. click on any video , select flash video


- Actual outcome:
user should be able to navigate the video with navigation key . but it does not happen
- Expected outcome:
user should be able to navigate the video with navigation key 
- Other info:

Flash Lite 3 is non released software part of web video program.

[Mahesh Kulkarni]

Created attachment 15138 [details]
Scroll support for plugin

As discussed,

1) Added NPPVariable variable NPPVPluginFocusPosition 
2) Added two MPluginNotifier EPluginActivated and EPluginDeactivated
3) Added memeber function MoveWindow in CPluginWin class 

When plugin is activated browser cursor will be hidden. Plugin updates browser with new position whenever it wants to move window. Browser takes offset value, updates its own cursor position (cursor hidden) and scrolls.

[Sachin Padma]

Comment on attachment 15138 [details]
Scroll support for plugin

patch does not apply. Please recheck the patch and create with latest codebase.

[Mahesh Kulkarni]

Created attachment 15216 [details]
Patch with lates tcode

Created patch with latest svn code

[Sachin Padma]

Comment on attachment 15216 [details]
Patch with lates tcode

Is this patch for 3.1 or ccb. Please specify. This patch does not apply in ccb. If 3.1 is it branch approved?

[Mahesh Kulkarni]

Created attachment 15458 [details]
3.1 patch - Scroll support for plugins

Branch approved for this TSW Error

[Mahesh Kulkarni]

Created attachment 15459 [details]
CCB patch - scroll support

Scroll support for CCB. Details of modifications are specified in above comments.

[Sachin Padma]

Comment on attachment 15458 [details]
3.1 patch - Scroll support for plugins

enum should always be added to the end. check npapi.h. What position is being substracted in ProcessEventL when position  is being passed to plugin

[Mahesh Kulkarni]

Created attachment 15699 [details]
3.1 patch - scroll support

In ProcessEventL, EEventActivate event sends the initial position where plugin should display its own cursor and also to handle click event to plugin. To give relative cursor position to plugin, subtracting current cursor position minus plugin start position. In which case plugin will get exact position where plugin is been clicked.

[Mahesh Kulkarni]

Created attachment 15700 [details]
CCB patch - Scroll support

Enums inserted at the end. There is one custom NPP variable already in CCB, adding new enum after that. For easy maintenances, starting custom NPP variable from 100 which can go up to 1000 according to NPP variable struct.

[Sachin Padma]

Comment on attachment 15699 [details]
3.1 patch - scroll support

Changing the value of existing enum will break BC.

[Mahesh Kulkarni]

Comment on attachment 15699 [details]
3.1 patch - scroll support

This does not modify any existing enum values. above Comments doesn't go with this patch. Resubmitting review request.

[Mahesh Kulkarni]

Created attachment 15742 [details]
CCB patch - After modifying enum value

Changed existing enum value to old value.

[Sachin Padma]

Comment on attachment 15742 [details]
CCB patch - After modifying enum value

Cannot change the values of previous entries in enum. Will break BC. Please fix this and then ask for review.

[Mahesh Kulkarni]

Comment on attachment 15699 [details]
3.1 patch - scroll support

Typo mistake. Rectified.

[Mahesh Kulkarni]

Created attachment 15804 [details]
CCB patch

Typo mistake. Rectified.

[Sachin Padma]

Comment on attachment 15699 [details]
3.1 patch - scroll support

r=me

[Sachin Padma]

Comment on attachment 15804 [details]
CCB patch

r=me

[Sachin Padma]

landed in r24958 & r24959

[Bradley Morrison]

Bulk closing of all s60 platform bugs. 

Sorry for the noise!