Bug 142372

Summary: Adjust volume box to not intersect with rest of inline controls
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch bfulgham: review+

Roger Fong
Reported 2015-03-05 17:05:58 PST
rdar://problem/20064327 Since the backgrounds are now transparent-ish we can’t just have the volume box and bottom control strip intersect anymore.
Attachments
patch (1.84 KB, patch)
2015-03-05 17:07 PST, Roger Fong 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2015-03-05 17:07:51 PST
Created attachment 248022 [details] patch
Brent Fulgham
Comment 2 2015-03-05 17:24:33 PST
Comment on attachment 248022 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=248022&action=review It would be nice to see a picture of what this change looks like, but I don't see anything obviously wrong with the changes. r=me. > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:199 > + width: 76px; Mmmmm! Magic numbers!
Roger Fong
Comment 3 2015-03-05 17:35:01 PST
http://trac.webkit.org/changeset/181122
Note You need to log in before you can comment on or make changes to this bug.