Summary: | [Win] JSC Build Warnings Need to be Resolved | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, bfulgham, cmarcelo, commit-queue, ggaren, mark.lam, msaboff, saam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Brent Fulgham
2015-03-05 15:23:32 PST
Created attachment 248320 [details]
the patch.
Comment on attachment 248320 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=248320&action=review > Source/JavaScriptCore/runtime/BasicBlockLocation.cpp:57 > + unsigned minIdx = (unsigned)-1; Maybe UINT_MAX since the previous line uses INT_MAX? Maybe std::numeric_limits<unsigned>::max() if we want to program in C++? (In reply to comment #2) > Maybe UINT_MAX since the previous line uses INT_MAX? Maybe > std::numeric_limits<unsigned>::max() if we want to program in C++? We have a practice of using (unsigned)-1 all over JSC, but I agree that it's time to move to using std::numeric_limits<unsigned>::max(). Will fix. Created attachment 248339 [details]
patch 2: applied Darin's feedback.
Comment on attachment 248339 [details]
patch 2: applied Darin's feedback.
r=me
Comment on attachment 248339 [details] patch 2: applied Darin's feedback. Clearing flags on attachment: 248339 Committed r181334: <http://trac.webkit.org/changeset/181334> All reviewed patches have been landed. Closing bug. |