Web Inspector: REGRESSION (r171645): up/down key navigation of timeline sidebar tree elements is broken when scope bar filters are applied

• Component: Web Inspector
• Status: RESOLVED FIXED

[Brian Burg]

Steps to reproduce:

1. Populate some timelines data
2. Select the Layout timeline
3. Select a scope bar filter for a record type that is non-contiguous (usually, Styles Invalidated and Styles Recalculated are fine)
4. Click on a record tree element in sidebar
5. Keyboard up/down until it stops working (beeps)

From my quick experiments, it appears that the sidebar content tree outline is rendered using the filtered tree elements, but pressing up/down keys tries to navigate to the next/previous unfiltered data grid node. If that node is filtered out, then nothing happens in response to key event (seems to eventually fire [NSResponder:noResponderFor] and beep.)

[Radar WebKit Bug Importer]

<rdar://problem/20048730>

[Matt Baker]

Caused by http://trac.webkit.org/changeset/171645.

Looking over TreeOutline.js, the real problem seems to be with traverseNextTreeElement and traversePreviousTreeElement. The above revision changed the criteria for tree elements being considered revealed, causing the latent bug in element traversal to manifest.

[Matt Baker]

Created attachment 254609 [details]
[Patch] Proposed Fix

[Timothy Hatcher]

Comment on attachment 254609 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=254609&action=review

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:1039
> +        var depthChange = 0;

Is this indent right?

[Matt Baker]

(In reply to comment #4)
> Comment on attachment 254609 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254609&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:1039
> > +        var depthChange = 0;
> 
> Is this indent right?

Could you clarify?

[Timothy Hatcher]

Comment on attachment 254609 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=254609&action=review

>>> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:1039
>>> +        var depthChange = 0;
>> 
>> Is this indent right?
> 
> Could you clarify?

The patch on my phone looks like this like is a 4 spaces less than it should be. It could be the rendering or maybe there is a tab?

[Matt Baker]

Comment on attachment 254609 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=254609&action=review

>>>> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:1039
>>>> +        var depthChange = 0;
>>> 
>>> Is this indent right?
>> 
>> Could you clarify?
> 
> The patch on my phone looks like this like is a 4 spaces less than it should be. It could be the rendering or maybe there is a tab?

Weird, it looks that way on my phone too. It looks correct on my laptop, and I confirmed that the indentation is identical to the line below it.

[WebKit Commit Bot]

Comment on attachment 254609 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 254609

Committed r185629: <http://trac.webkit.org/changeset/185629>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.