Bug 142304

Summary:

Only Heap should be in charge of deciding how to select a subspace for a type

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

141174

Attachments:

Description	Flags
the patch	mark.lam: review+

Description Filip Pizlo 2015-03-04 12:57:17 PST

Currently the DFG, FTL, and JSCellInlines have some code duplication to decide which subspace/allocator to use for which type.  While working on bug 141174, I realized that I'll need to repeat this pattern again, and so I decided to reduce the code duplication somewhat.

Comment 1 Filip Pizlo 2015-03-04 12:59:38 PST

Created attachment 247885 [details]
the patch

Comment 2 Mark Lam 2015-03-04 13:01:57 PST

Comment on attachment 247885 [details]
the patch

r=me

Comment 3 Filip Pizlo 2015-03-04 13:33:14 PST

Landed in http://trac.webkit.org/changeset/181019