| Summary: | [GTK] Web Inspector: New Images for Console Types | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Andres Gomez Garcia <agomez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | agomez, cgarcia, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
The New Images were added for: <https://webkit.org/b/141932> Web Inspector: New Object Tree View UI (In reply to comment #0) > * SUMMARY > My understanding is GTK has their own Inspector Images. Yes. > We just added a number of images for Inspector Console Types: > > UserInterface/Images/Eye.svg > UserInterface/Images/TypeBoolean.svg > UserInterface/Images/TypeNull.svg > UserInterface/Images/TypeNumber.svg > UserInterface/Images/TypeObject.svg > UserInterface/Images/TypeRegex.svg > UserInterface/Images/TypeString.svg > UserInterface/Images/TypeSymbol.svg > UserInterface/Images/TypeUndefined.svg > > So GTK folks will likely want to include images for them. Thank you for let us know. Created attachment 249535 [details]
Patch
Comment on attachment 249535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249535&action=review rs=me! - Note we're in the process of considering a new icon (Pencil) for Setters as a corollary for the Eye for Getters. I'll keep you informed if we do. I'll file bugs for you. > Source/WebInspectorUI/UserInterface/Images/gtk/ReloadFull.svg:1 > +<?xml version="1.0" encoding="UTF-8" standalone="no"?> Oh nice! You found the ReloadFull.svg I just added. I forgot to update this bug. > Source/WebInspectorUI/UserInterface/Images/gtk/ReloadFull.svg:14 > +<!-- Created with Inkscape (http://www.inkscape.org/) --> > + > +<svg > + xmlns:dc="http://purl.org/dc/elements/1.1/" > + xmlns:cc="http://creativecommons.org/ns#" > + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" > + xmlns:svg="http://www.w3.org/2000/svg" > + xmlns="http://www.w3.org/2000/svg" > + version="1.1" > + width="13" > + height="13" > + id="svg5505"> > + <defs You may want to consider stripping unnecessary attributes / comments / verbosity from these SVGs. I have a feeling some of the attributes can be eliminated. (In reply to comment #5) > - Note we're in the process of considering a new icon (Pencil) for Setters > as a corollary for the Eye for Getters. I'll keep you informed if we do. > > I'll file bugs for you. Great! Really appreciated :) > > Source/WebInspectorUI/UserInterface/Images/gtk/ReloadFull.svg:14 > > +<!-- Created with Inkscape (http://www.inkscape.org/) --> > > + > > +<svg > > + xmlns:dc="http://purl.org/dc/elements/1.1/" > > + xmlns:cc="http://creativecommons.org/ns#" > > + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" > > + xmlns:svg="http://www.w3.org/2000/svg" > > + xmlns="http://www.w3.org/2000/svg" > > + version="1.1" > > + width="13" > > + height="13" > > + id="svg5505"> > > + <defs > > You may want to consider stripping unnecessary attributes / comments / > verbosity from these SVGs. I have a feeling some of the attributes can be > eliminated. Yeah, I've been thinking about it. Not sure about stripping the information about the license but, definitively, there is quite some unneeded attributes, including gradients Inkscape refuses to remove even if no items are using them in the current document. I have to find the time to look for a nice way to do this without having to go one icon after another. Thanks for the heads up anyway. Comment on attachment 249535 [details] Patch Clearing flags on attachment: 249535 Committed r182048: <http://trac.webkit.org/changeset/182048> All reviewed patches have been landed. Closing bug. |
* SUMMARY My understanding is GTK has their own Inspector Images. We just added a number of images for Inspector Console Types: UserInterface/Images/Eye.svg UserInterface/Images/TypeBoolean.svg UserInterface/Images/TypeNull.svg UserInterface/Images/TypeNumber.svg UserInterface/Images/TypeObject.svg UserInterface/Images/TypeRegex.svg UserInterface/Images/TypeString.svg UserInterface/Images/TypeSymbol.svg UserInterface/Images/TypeUndefined.svg So GTK folks will likely want to include images for them.