| Summary: | Make JavaScript binding get and set legacy event listener attributes directly | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||
| Component: | WebCore JavaScript | Assignee: | Darin Adler <darin> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, andersca, buildbot, commit-queue, kling, ossy, rniwa, sam | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Bug Depends on: | 142307 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Darin Adler
2015-03-04 08:50:30 PST
Created attachment 247862 [details]
Patch
Attachment 247862 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSEventListener.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 247862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247862&action=review As we discussed, we should probably stick with one name or the other (attributeEventListener vs. eventListenerAttribute +/- legacy). I am leaning on the side of eventListenerAttribute right now, though in the past, I was clearly in the attributeEventListener camp. Either way, r=me. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2302 > + my $eventName = LegacyEventListenerAttributeEventName($implGetterFunctionName); This would probably be cleaner if it took the $attribute like LegacyEventListenerAttributePrefix does. That way, if we can more easily fix the special cases in it via new extended attributes. Committed r181001: <http://trac.webkit.org/changeset/181001> Bindings tests fixed in http://trac.webkit.org/changeset/181003 (In reply to comment #4) > Committed r181001: <http://trac.webkit.org/changeset/181001> It made 16 tests timeout. Will roll out (sorry for not doing it earlier). Re-opened since this is blocked by bug 142307 I figured out one thing that went wrong yesterday. I had missed that the "ondisplay" attribute on Notification is for the "show" event, not the "display" event. Created attachment 247957 [details]
Patch
Attachment 247957 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSEventListener.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
New patch covers most of what was causing tests to fail last time, but not yet 100% sure it covers all of it. Running tests now. Comment on attachment 247957 [details] Patch Attachment 247957 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4675936054149120 New failing tests: fast/workers/worker-multi-port.html http/tests/notifications/legacy/show.html http/tests/notifications/legacy/window-show-on-click.html http/tests/notifications/events.html http/tests/notifications/legacy/events.html fast/history/page-cache-notification-suspendable.html fast/events/message-channel-gc-4.html http/tests/notifications/show.html fast/workers/worker-context-multi-port.html fast/events/message-port-clone.html fast/workers/worker-messageport.html http/tests/notifications/legacy/double-show.html http/tests/notifications/window-show-on-click.html fast/events/message-port-multi.html fast/events/message-port.html fast/workers/worker-messageport-gc.html fast/events/message-channel-gc-3.html Created attachment 247962 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 247957 [details] Patch Attachment 247957 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6265944221417472 New failing tests: fast/workers/worker-multi-port.html http/tests/notifications/legacy/show.html http/tests/notifications/legacy/window-show-on-click.html http/tests/notifications/legacy/double-show.html http/tests/notifications/legacy/events.html fast/history/page-cache-notification-suspendable.html fast/events/message-channel-gc-4.html http/tests/notifications/show.html http/tests/notifications/window-show-on-click.html fast/workers/worker-context-multi-port.html fast/events/message-port-clone.html fast/workers/worker-messageport.html http/tests/notifications/events.html fast/events/message-port-multi.html fast/events/message-port.html fast/workers/worker-messageport-gc.html fast/events/message-channel-gc-3.html Created attachment 247966 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 248043 [details]
Patch
Attachment 248043 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSEventListener.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The new patch I attached has fixes for all the failures we have been seeing in the EWS and buildbot. The common thread in all of them was custom code in setOnxxx functions that I missed the first time around, but was able to local with a simple grep. Committed r181156: <http://trac.webkit.org/changeset/181156> |