Bug 14228

Summary: [S60] Browser : On going download files from Browser can be seen in Music Shop
Product: WebKit Reporter: Prashanth Gedde Narayanaswamy <prashanth.narayanaswamy>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Critical CC: Sachin.Padma
Priority: P1    
Version: 523.x (Safari 3)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
URL: http://bhlns01/NMP/MSW/S60Errors.nsf/drd/E60CBB8AB686215B882572F9005F3BA8?OpenDocument
Attachments:
Description Flags
Fix for using the app Uid passed by client
Sachin.Padma: review-
Removed Tabs from source code Sachin.Padma: review+

Description Prashanth Gedde Narayanaswamy 2007-06-19 02:31:55 PDT
TSW Error Id : SKWK-745NC7 - Browser : On going download files from Browser can be seen in Music Shop

- Use case:
Running the OSS Browser first and then leave the downloaded files in Download menu without saving them.  
Turn off phone, and start up again with Music Shop, then these songs will be in the Download Menu of the MusicShop.

- Steps to reproduce:
1. Start OSS Browser
2. Download a few mp3 files from www.cdmamail.com/qalabs/filedown/audio/MP3
3. Turn off phone.
4. Power up again and start Music Shop first.
5. Options-Downloads 

- Actual outcome:
Download menu from Music Shop show the same files that were being downloaded in step 2 above from Browser.

- Expected outcome:
No Download menu available after Step 4. Same files are not being show on MusicShop

- Other info:
Started a download from MusicShop, when I checked CMusicShopBrowserDownloadObserver::NewDownloadL, the download folder aFileName is 
C:\\system\\dmgr\\10008d39\\contents\\filename.mp3

10008d39 is the Browser App UID. I think this is wrong. It should show MusicShop App UID instead?

The problem is the httpdownloadobserver is hardcoding the  KCRUidBrowser(10008d39) when connecting to the DL Mgr Server.
Comment 1 Prashanth Gedde Narayanaswamy 2007-06-19 03:30:53 PDT
Created attachment 15117 [details]
Fix for using the app Uid passed by client

TSW Error ID : SKWK-745NC7 - On going download files from Browser can be seen in Music Shop

The problem was due to the use of hardcoded browser's app Uid while connecting to the download manager server. For any client application, resource loader's CHTTPDownloadObserver used to send Browser's App Uid.

This has been fixed, to use the client application Uid which will be passed while connecting to DM server. The app Uid will be stored in CLoaderContainer . Also Set and Get functions have been added to CLoaderContainer which will be used by CWebKitControl for setting and HttpDownloadObeserver for getting the app Uid.

While connecting to the Download Manager server this Uid which is saved in LoaderContainer is used instead of hardcoding the Uid.
Comment 2 Sachin Padma 2007-06-26 07:51:53 PDT
Comment on attachment 15117 [details]
Fix for using the app Uid passed by client

r=me
Comment 3 Sachin Padma 2007-06-26 07:53:02 PDT
Comment on attachment 15117 [details]
Fix for using the app Uid passed by client

patch contains tabs. Tabs are not allowed
Comment 4 Prashanth Gedde Narayanaswamy 2007-06-26 22:20:11 PDT
Created attachment 15263 [details]
Removed Tabs from source code

Removed Tabs from source code
Comment 5 Sachin Padma 2007-06-28 11:48:53 PDT
Comment on attachment 15263 [details]
Removed Tabs from source code

r=me
Comment 6 Sachin Padma 2007-06-28 12:07:25 PDT
landed in r23856
Comment 7 Bradley Morrison 2008-04-09 11:39:25 PDT
Bulk closing of all s60 platform bugs. 

Sorry for the noise!