Bug 142278

Summary:

Silence GCC's -Wstrict-prototypes

Product:

WebKit

Reporter:

Debarshi Ray <rishi.is>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Debarshi Ray 2015-03-04 08:14:27 PST

In ANSI C, one must specify the argument types (even if it is void) in a function prototype. Otherwise GCC complains. I have gcc-4.9.2 here.

In file included from /usr/include/webkitgtk-4.0/JavaScriptCore/JavaScript.h:31:0,
                 from goawebview.c:27:
/usr/include/webkitgtk-4.0/JavaScriptCore/JSContextRef.h:51:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
 JS_EXPORT JSContextGroupRef JSContextGroupCreate() CF_AVAILABLE(10_6, 7_0);
 ^

Comment 1 Debarshi Ray 2015-03-04 11:06:51 PST

Created attachment 247871 [details]
Patch

Comment 2 WebKit Commit Bot 2015-03-04 17:52:21 PST

Comment on attachment 247871 [details]
Patch

Clearing flags on attachment: 247871

Committed r181059: <http://trac.webkit.org/changeset/181059>

Comment 3 WebKit Commit Bot 2015-03-04 17:52:23 PST

All reviewed patches have been landed.  Closing bug.