| Summary: | Web Inspector: Array/Collection Sizes should be visible and distinct | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Joseph Pecoraro
2015-03-03 20:39:02 PST
Created attachment 247830 [details]
[IMAGE] Work in Progress
This is the work in progress. I have this implemented, I just need to write tests and update existing tests for the subtle protocol changes, and test backwards compatibility.
Comment on attachment 247830 [details]
[IMAGE] Work in Progress
Looks good.
Created attachment 247903 [details]
[PATCH] Proposed Fix
The attached patch even fixes: > [1, 2, 3, 4, Array...] To be: > [1, 2, 3, 4, Array (7)...] Though we may decide to style this differently, so there is no confusion? > [1, 2, 3, 4, Array[7]...] In any case... it can be addressed later. Comment on attachment 247903 [details]
[PATCH] Proposed Fix
It is unfortunate that ObjectPreview, PropertyPreview and RemoteObject can't share more.
(In reply to comment #5) > The attached patch even fixes: > > > [1, 2, 3, 4, Array...] > > To be: > > > [1, 2, 3, 4, Array (7)...] > > Though we may decide to style this differently, so there is no confusion? > > > [1, 2, 3, 4, Array[7]...] > > In any case... it can be addressed later. I kind of want Array and Objects to be: [1, 2, 3, 4, [...], ...] [1, 2, 3, 4, {...}, ...] [1, 2, 3, 4, MyObject {...}, ...] I'm not sure the size should be in previews. But maybe there is a clever way to show the size inside the []? Kind of like how had with "undefined x 2". (In reply to comment #7) > (In reply to comment #5) > > The attached patch even fixes: > > > > > [1, 2, 3, 4, Array...] > > > > To be: > > > > > [1, 2, 3, 4, Array (7)...] > > > > Though we may decide to style this differently, so there is no confusion? > > > > > [1, 2, 3, 4, Array[7]...] > > > > In any case... it can be addressed later. > > I kind of want Array and Objects to be: > > [1, 2, 3, 4, [...], ...] > [1, 2, 3, 4, {...}, ...] > [1, 2, 3, 4, MyObject {...}, ...] I like this! > I'm not sure the size should be in previews. But maybe there is a clever way > to show the size inside the []? Kind of like how had with "undefined x 2". It is easy to remove them from property previews. If we choose not to, we should not send that information from on the backend. I'll send out a new version that doesn't include size in PropertyPreview. Just for RemoteObject / Object Preview (the top level preview). > > [1, 2, 3, 4, [...], ...]
> > [1, 2, 3, 4, {...}, ...]
> > [1, 2, 3, 4, MyObject {...}, ...]
If we wanted something like:
> [1, 2, 3, 4, [..(5)..], ...] (10)
We would need to pass the size for PropertyPreviews.
Created attachment 247911 [details]
[PATCH] Proposed Fix - No Size in Property Preview
Created attachment 247912 [details]
[DIFF] Diff between Proposed Fix 1 and 2 (PropertyPreview support)
Comment on attachment 247911 [details] [PATCH] Proposed Fix - No Size in Property Preview Clearing flags on attachment: 247911 Committed r181061: <http://trac.webkit.org/changeset/181061> All reviewed patches have been landed. Closing bug. |