Bug 142247

Summary:

[WebEditingTester] Add support for the find and replace bar

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Tools / Tests

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, enrica, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	enrica: review+

Description Tim Horton 2015-03-03 16:48:56 PST

While it's not hooked up yet in WKWebView, adding support for the find bar to WebEditingTester will help us implement that functionality.

Comment 1 Tim Horton 2015-03-03 16:49:14 PST

Created attachment 247815 [details]
patch

Comment 2 WebKit Commit Bot 2015-03-03 16:51:42 PST

Attachment 247815 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Tools/WebEditingTester/WK2WebDocumentController.m:132:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Enrica Casucci 2015-03-03 18:21:28 PST

Comment on attachment 247815 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247815&action=review

Great!

> Tools/ChangeLog:15
> +        Recieve performTextFinderAction: and forward it to the frontmost WebDocumentController.

typo receive.

Comment 4 Tim Horton 2015-03-04 11:28:25 PST

http://trac.webkit.org/changeset/181007