Bug 142226 – [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

LayoutTests/platform/wk2/TestExpectations contains expectations for all (or Apple-only?) WebKit2 ports, so they are less-specific than LayoutTests/platform/ios-simulator/TestExpectations, which are shared test expectations for both WK1 and WK2 tests on iOS Simulator.

The current order for ios-simulator-wk2 is this:  ios-simulator-wk2, wk2, ios-simulator

I propose changing it to this:  ios-simulator-wk2, ios-simulator, wk2

This has the additional benefit of fixing the expected results for this test because it's marked as [ Failure ] in wk2, but [ Skip ] in ios-simulator:

fast/dynamic/window-resize-scrollbars-test.html

[David Kilzer (:ddkilzer)]

Created attachment 247770 [details]
Patch v1

[David Kilzer (:ddkilzer)]

(In reply to comment #0)
> This has the additional benefit of fixing the expected results for this test
> because it's marked as [ Failure ] in wk2, but [ Skip ] in ios-simulator:
> 
> fast/dynamic/window-resize-scrollbars-test.html

And I think switching the order of test expectations for ios-simulator-wk2 is better than trying to move the [ Failure ] expectation from platform/wk2/TestExpectations to somewhere else (namely each port-specific TestExpectations file).

[Alexey Proskuryakov]

What is the order on Mac?

For expected results, it's "mac-wk2 -> wk2 -> mac-mavericks -> mac -> generic" (on Mavericks), but I'm not quite sure what the order is for TestExpectations.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> What is the order on Mac?
> 
> For expected results, it's "mac-wk2 -> wk2 -> mac-mavericks -> mac ->
> generic" (on Mavericks), but I'm not quite sure what the order is for
> TestExpectations.

For mac-yosemite-wk2, it is:  mac-wk2, wk2, mac

Which is basically the same as the "Baseline search path" without "generic" at the end.

I assume the TestExpectations files are parsed in the same order as the test results, or nothing would really make sense.  :)

What am I missing here?  Should the [ Failure ] result for fast/dynamic/window-resize-scrollbars-test.html move out of wk2/TestExpectations (and into mac-wk2/TestExpectations?) so the [ Skip ] result in ios-simulator/TestExpectations is recognized?

[Darin Adler]

Oops, I didn’t see Alexey’s question.

[WebKit Commit Bot]

Comment on attachment 247770 [details]
Patch v1

Clearing flags on attachment: 247770

Committed r181131: <http://trac.webkit.org/changeset/181131>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.