Bug 142224
| Summary: | BitStack::top() should calculate an index instead of always using m_words.last() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | W. James MacLean <wjmaclean> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | All | ||
W. James MacLean
BitStack::push() calculates an index based on m_size to determine where the new entry is supposed to go.
However, BitStack::top() always looks up the bit value using m_words.last(), which can be wrong if popping elements has caused m_size to point into a word other than the last one (simple test: push 'true' 33 times, then pop() once and call top() ... it will read 'false'.)
BitStack::top() should instead calculate an index the same as push().
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 258190@main (409456bc5cee): <https://commits.webkit.org/258190@main>
Reviewed commits have been landed. Closing PR #7888 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/103597584>