Bug 142219 – [buildbot] mastercfg_unittest.py should be runnable easily

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

Now mastercfg_unittest.py isn't runnable out-of-the-box, because newer 
twisted moved NoResource from twisted.web.error to twisted.web.resource .

The short term fix is to autoinstall the twisted version 
used by build.webkit.org buildmaster - Twisted 12.1.0 .

I'm on it, patch is coming soon.

[Csaba Osztrogonác]

Created attachment 247935 [details]
Patch

With this fix mastercfg_unittest.py works out-of-the-box on Linux and Mac too. The next step will be to run it automatically on the bots.

[Alexey Proskuryakov]

For the ignorant among us, how does one run a python unit test "out of the box"? Is there a specific command?

The only thing I know how to use is test-webkitpy, and then (barely) buildbot's checkconfig.

[Csaba Osztrogonác]

(In reply to comment #2)
> For the ignorant among us, how does one run a python unit test "out of the
> box"? Is there a specific command?
> 
> The only thing I know how to use is test-webkitpy, and then (barely)
> buildbot's checkconfig.

cd Tools/BuildSlaveSupport/build.webkit.org-config
./mastercfg_unittest.py

Unfortunately test-webkitpy can't run unit tests in build.webkit.org-config
for some reason, for example "." and "-" characters in the directory name.

I tried to rename the directory and add it to test-webkitpy,
but it isn't enough, there are more issues should be fixed.

[Csaba Osztrogonác]

One more thing: You can't run each unittest in webkitpy by hand, because
they don't have this code at the end and don't have execute bit:

if __name__ == '__main__':
    unittest.main()

test-webkitpy collects/executes unit tests parallel in a different way.

[Chris Dumez]

I tested this patch and was able to run mastercfg_unittest.py on Mac.

[Chris Dumez]

Comment on attachment 247935 [details]
Patch

r=me.

[WebKit Commit Bot]

Comment on attachment 247935 [details]
Patch

Clearing flags on attachment: 247935

Committed r181088: <http://trac.webkit.org/changeset/181088>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.