Bug 14221

Summary: Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Test case
none
Avoid updating the style of first-letter containers when updating 'before' content darin: review+

mitz
Reported 2007-06-18 14:10:04 PDT
ASSERTION FAILED: oldText (/WebKit/WebCore/rendering/RenderBlock.cpp:4123 virtual void WebCore::RenderBlock::updateFirstLetter()) To reproduce the bug, open the test case with a debug build and click the Test button.
Attachments
Test case (312 bytes, text/html)
2007-06-18 14:10 PDT, mitz 		no flags
Details
Avoid updating the style of first-letter containers when updating 'before' content (36.21 KB, patch)
2007-07-07 07:08 PDT, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2007-06-18 14:10:35 PDT
Created attachment 15108 [details] Test case
mitz
Comment 2 2007-06-18 14:14:14 PDT
Changing to P1 since release builds eventually crash when destroying the page.
mitz
Comment 3 2007-06-18 15:37:55 PDT
The actual bug is that RenderContainer::updateBeforeAfterContentForContainer() doesn't know how to update the old content's style if it also has a first-letter pseudo-element style. The update loops assumes that the children of the before/after generated content container are either text renderers or images, and that they all have the BEFORE or AFTER style type.
mitz
Comment 4 2007-07-07 07:08:49 PDT
Created attachment 15431 [details] Avoid updating the style of first-letter containers when updating 'before' content Includes change log and layout test. This patch does not address the fact that 'before' content is always nested so with non-layout style changes you still get bug 14550, but no crash.
Darin Adler
Comment 5 2007-07-07 12:50:45 PDT
Comment on attachment 15431 [details] Avoid updating the style of first-letter containers when updating 'before' content r=me
Mark Rowe (bdash)
Comment 6 2007-07-08 02:56:37 PDT
Landed in r24094.
Note You need to log in before you can comment on or make changes to this bug.