|Summary:||REGRESSION (r180907): inspector/timeline tests frequently time out or fail|
|Product:||WebKit||Reporter:||Brent Fulgham <bfulgham>|
|Component:||Web Inspector||Assignee:||Matt Baker <mattbaker>|
|Severity:||Normal||CC:||ap, bfulgham, ggaren, graouts, inspector-bugzilla-changes, jonowells, mark.lam, webkit-bug-importer|
|Version:||528+ (Nightly build)|
Description Brent Fulgham 2015-03-02 20:10:16 PST
The following layout tests are failing on Windows due to timeouts. According to test history, they actually seem to timeout or be very flaky on all platforms. inspector/timeline/debugger-paused-while-recording.html inspector/timeline/exception-in-injected-script-while-recording.html
Comment 2 Alexey Proskuryakov 2015-03-02 21:52:30 PST
This looks like a regression from <http://trac.webkit.org/r180907>: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Ftimeline%2Fexception-in-injected-script-while-recording.html Should we roll out?
Comment 3 Brent Fulgham 2015-03-02 21:56:37 PST
(In reply to comment #2) > This looks like a regression from <http://trac.webkit.org/r180907>: > > https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=inspector%2Ftimeline%2Fexception-in-injected- > script-while-recording.html > > Should we roll out? I think so. if we leave it skipped I think it may just join the dozen other inspector-related bugs and timeouts that have been left unaddressed.
Comment 4 Mark Lam 2015-03-02 22:45:45 PST
(In reply to comment #3) > (In reply to comment #2) > > This looks like a regression from <http://trac.webkit.org/r180907>: > > > > https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard. > > html#showAllRuns=true&tests=inspector%2Ftimeline%2Fexception-in-injected- > > script-while-recording.html > > > > Should we roll out? > > I think so. if we leave it skipped I think it may just join the dozen other > inspector-related bugs and timeouts that have been left unaddressed. I disagree. I added a test inspector/timeline/exception-in-injected-script-while-recording.html which is based on inspector/timeline/debugger-paused-while-recording.html. Note that the original test was previously excluded, and I fixed a bug for it and unskipped the test (see http://trac.webkit.org/changeset/180901). I was warned that the test was seen to be flaky before, but I since I fixed one issue for it, and I wasn't able to reproduce the flakiness locally, I unskipped the test. The proper remedy is to restore the skipping inspector/timeline again. I will do this while I take a second look at why the tests can flake now that I have examples of their flakiness to study.
Comment 5 Mark Lam 2015-03-02 22:59:17 PST
I've restored the skipping of the inspector/timeline directory in r180922: <http://trac.webkit.org/r180922>.
Comment 6 Mark Lam 2015-03-02 23:39:12 PST
From the bots, it looks like the flaky failures are a lot more reproducible if we run with webkit2 instead of webkit1. I was able to reproduce this locally.
Comment 7 Joseph Pecoraro 2015-07-30 17:33:56 PDT
These tests now ASSERT under InspectorTimelineAgent::willComposite. Likely due to that not handling nesting well.